Re: [PATCH] time: Fix adjustment cleanup bug in timekeeping_adjust()

[John Stultz]

On 08/04/2012 12:21 PM, Ingo Molnar wrote:
> * Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > Hello.
> >
> > Bisected to 2a8c0883 "time: Move xtime_nsec adjustment
> > underflow handling timekeeping_adjust".
> >
> > Would you check?
> probably caused by this stray return in timekeeping_adjust():
>
>          } else
>                  return;
>
> which should really be a proper goto - like the (totally
> untested!) patch below.

Ooof.   Your analysis looks correct, thanks for fixing this, Ingo!
And thanks for catching the issue Tetsuo!

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/