Re: [PATCH 0/2] ptrace: DEBUGCTLMSR_BTF fixes

From: Sebastian Andrzej Siewior
Date: Mon Aug 06 2012 - 12:15:04 EST


On 08/03/2012 06:29 PM, Oleg Nesterov wrote:

Assuming this series passes the review of course. And it would
be really nice if someone reviews 2/2, I am not confident that
I fully understand this DEBUGCTLMSR_BTF magic.

Here is how the processor disables the BTF:

| The processor clears the BTF flag when it generates a debug
| exception. The debugger must set the BTF flag before resuming program
| execution to continue single-stepping on branches.

This was a quote from "253668-039US, May 2011" page 16-17.

So I think __switch_to_extra() should set the bit before putting the
task on the CPU. If this bit is enabled on the wrong CPU then in will
remain set forever if single steeping has not been / will not be
enabled.

Oleg.


Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/