Re: [PATCH 1/5] staging/csr: clean coding style in uf_start_thread

From: Dan Carpenter
Date: Mon Aug 06 2012 - 09:55:56 EST


This was sent encoded as base64 which is awkward.

On Sat, Aug 04, 2012 at 01:01:38PM +0545, Devendra Naga wrote:
> - } else {
> - priv->bh_thread.prio = DEFAULT_PRIO;
> - }
> + } else
> + priv->bh_thread.prio = DEFAULT_PRIO;

Probably it's not worth resending if this is the only complaint, but
actually the original had that braces correct. If either side of
the if else statement gets uses curly braces then both sides should
use them.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/