Re: [Patch] string: do not export memweight() to userspace

From: Akinobu Mita
Date: Mon Aug 06 2012 - 08:40:41 EST


2012/8/6 Cong Wang <amwang@xxxxxxxxxx>:
> From: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>
> This patch fixes the following warning:
>
> usr/include/linux/string.h:8: userspace cannot reference function or variable defined in the kernel

Thanks for finding this problem.
Looks good to me.

> Cc: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>
>
> ---
> diff --git a/include/linux/string.h b/include/linux/string.h
> index ffe0442..b917881 100644
> --- a/include/linux/string.h
> +++ b/include/linux/string.h
> @@ -144,8 +144,8 @@ static inline bool strstarts(const char *str, const char *prefix)
> {
> return strncmp(str, prefix, strlen(prefix)) == 0;
> }
> -#endif
>
> extern size_t memweight(const void *ptr, size_t bytes);
>
> +#endif /* __KERNEL__ */
> #endif /* _LINUX_STRING_H_ */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/