Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

From: Felipe Balbi
Date: Mon Aug 06 2012 - 05:34:03 EST


On Mon, Aug 06, 2012 at 02:58:44PM +0530, Sourav Poddar wrote:
> There is an automatic binding done for I2C devices in the of_i2c core
> code. So, DT will be able to bind to any I2C device using the
> already existing table: MODULE_DEVICE_TABLE(i2c, bmp085_id).
>
> Tested on omap5430 evm.
>
> Cc: Benoit Cousson <b-cousson@xxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx>

Acked-by: Felipe Balbi <balbi@xxxxxx>

> ---
> drivers/misc/bmp085-i2c.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/misc/bmp085-i2c.c b/drivers/misc/bmp085-i2c.c
> index 9943971..a4f33c9 100644
> --- a/drivers/misc/bmp085-i2c.c
> +++ b/drivers/misc/bmp085-i2c.c
> @@ -57,12 +57,6 @@ static int bmp085_i2c_remove(struct i2c_client *client)
> return bmp085_remove(&client->dev);
> }
>
> -static const struct of_device_id bmp085_of_match[] = {
> - { .compatible = "bosch,bmp085", },
> - { },
> -};
> -MODULE_DEVICE_TABLE(of, bmp085_of_match);
> -
> static const struct i2c_device_id bmp085_id[] = {
> { BMP085_NAME, 0 },
> { "bmp180", 0 },
> @@ -74,7 +68,6 @@ static struct i2c_driver bmp085_i2c_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = BMP085_NAME,
> - .of_match_table = bmp085_of_match
> },
> .id_table = bmp085_id,
> .probe = bmp085_i2c_probe,
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
balbi

Attachment: signature.asc
Description: Digital signature