Re: [PATCH 1/4] arm/dts: omap5-evm: Add I2C support

[Felipe Balbi]

Hi,

On Fri, Aug 03, 2012 at 09:22:19PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/03/2012 04:38 PM, Sourav Poddar wrote:
> 
> > Add I2C data node in omap5 device tree file.
> 
> > Tested on omap5430 sdp.
> 
> > Cc: Benoit Cousson <b-cousson@xxxxxx>
> > Cc: Felipe Balbi <balbi@xxxxxx>
> > Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> > Acked-by: Felipe Balbi <balbi@xxxxxx>
> > Signed-off-by: Sourav Poddar <sourav.poddar@xxxxxx>
> > ---
> >  arch/arm/boot/dts/omap5.dtsi |   35 +++++++++++++++++++++++++++++++++++
> >  1 files changed, 35 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> > index 57e5270..6b68dfe 100644
> > --- a/arch/arm/boot/dts/omap5.dtsi
> > +++ b/arch/arm/boot/dts/omap5.dtsi
> > @@ -145,6 +145,41 @@
> >  			#interrupt-cells = <1>;
> >  		};
> >  
> > +		i2c1: i2c@48070000 {
> > +			compatible = "ti,omap4-i2c";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			ti,hwmods = "i2c1";
> 
>    Address postfix in the node name and no "reg" property?

that's because of the ti,hwmods attribute. OMAP is still not entirely
converted to DT and there's this weird ti,hwmods attribute. OMAP's hwmod
framework will fill up register addresses, irqs, etc when the device is
created. Oh well...

-- 
balbi

Attachment: signature.asc
Description: Digital signature