Re: [PATCH] extcon: arizona: Implement button detection support

[Mark Brown]

On Sat, Aug 04, 2012 at 12:07:34PM +0530, anish kumar wrote:

> According to my discussion with Mr. Myunjoo Ham.He said that single
> driver should not be used for communicating with both extcon and input
> subsystem and that is the reason he suggested that I split the samsung
> jack driver into two separate drivers.

> First driver to communicate with extcon about headset insertion/removal.
> Second driver is to communicate with input subsystem to report headset
> button press/release.

> I have followed this approach and coded and it seems to be working fine,
> but looking at this patch I feel there is no need to separate as
> both insertion/removal and button press/release is reported using a
> single driver.
> I am good with any approach but just wanted to let you know what I am
> going to post soon.

For this hardware splitting really isn't practical - the hardware and
state machine for button interaction and basic detection are the same,
I think all we could do with separate drivers is have a core which
called back into subdrivers which have the sole purpose of propagating
reports up the stack.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/