Re: [PATCH] scripts/get_maintainer.pl: Default to --no-rolestatswhen output not a terminal

[Josh Triplett]

On Fri, Aug 03, 2012 at 11:33:21AM -0700, Joe Perches wrote:
> On Fri, 2012-08-03 at 11:27 -0700, Josh Triplett wrote:
> > scripts/get_maintainer.pl defaults to showing --rolestats, which
> > provides annotations explaining why each person or list might want to
> > know about a patch.  This works well for interactive use, but breaks
> > when used with git send-email's --to-cmd or --cc-cmd, resulting in
> > malformed email headers and mails sent to some but not all recipients.
> > 
> > To avoid the need to explicitly pass --no-rolestats for batch use,
> > enable --rolestats by default only when outputting to a terminal.
> 
> Hi Josh.
> 
> I think it's preferable to add --no-rolestats
> to the uses that need them.

Why?

> I have different scripts that I use for git send-email
> options --to-cmd and --cc-cmd
[...snip scripts...]

You've submitted enough patches that you've automated as much of the
process as you can; I don't think that makes the defaults less
error-prone.  Given that you've had to explicitly add --no-rolestats to
your scripts, that seems like evidence in *favor* of making this change.

As it stands now, the current default of --rolestats makes the obvious
command line of
git send-email --to-cmd='scripts/get_maintainer.pl' *.patch
send broken emails that go to some maintainers but not all.  I think it
makes sense to change the default so that the obvious usage becomes the
correct one.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/