Re: [PATCH] samples/seccomp: fix endianness bug in LO_ARG define

From: James Morris
Date: Fri Aug 03 2012 - 00:38:10 EST


On Tue, 31 Jul 2012, Kees Cook wrote:

> On Tue, Jul 31, 2012 at 7:15 AM, Heiko Carstens
> <heiko.carstens@xxxxxxxxxx> wrote:
> > From: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> >
> > The LO_ARG define needs to consider endianness also for 32 bit builds.
> >
> > The "bpf_fancy" test case didn't work on s390 in 32 bit and compat mode
> > because the LO_ARG define resulted in a BPF program which read the upper
> > halve of the 64 bit system call arguments instead of the lower halves.
> >
> > Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
>
> Good catch; thanks for the fix!
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next


--
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/