Re: [PATCH] kbuild: kvm: make export of linux/kvm_para.hunconditional

[Sam Ravnborg]

On Thu, Aug 02, 2012 at 05:19:20PM +0300, Avi Kivity wrote:
> On 08/02/2012 03:25 PM, Will Deacon wrote:
> > On Thu, Jul 26, 2012 at 02:44:14PM +0100, Will Deacon wrote:
> >> The asm-generic version of kvm_para.h is always exported, confusing the
> >> Kbuild wildcarding that tries to detect whether the source architecture
> >> is exporting the header, since asm-* matches the generic version.
> >> 
> >> This patch unconditionally exports linux/kvm_para.h and fixes the few
> >> remaining architectures without asm/kvm_para.h to use the generic
> >> version. I also took the liberty of removing some dead lines from the
> >> wildcarding which was searcing for asm-$(SRCARCH) directores under
> >> $(srctree).
> >> 
> >> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> >> Cc: Avi Kivity <avi@xxxxxxxxxx>
> >> Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> >> ---
> > 
> > Any further comments on this? It fixes header generation for me, so it would
> > be nice to see it merged.
> 
> Can you get it reviewed by someone who is familiar with this?  This is
> probably the third fix for the this issue.

IMO the patch is wrong.
Any use of wildcards in include/asm-generic/Kbuild.asm is wrong.

IMO include/asm-generic/Kbuild.asm is for generic header files
that ALL archs can use.

If not ALL archs can use it, then the individual arch shall
specify the file explicit.

I know we here hit a bad thing with the generic-y support,
where we miss a good way to add a file to a lot of archs
without editing a lot of files.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/