Re: [PATCH v2] [S390] do not clobber personality flags insys_32_personality()

From: Heiko Carstens
Date: Thu Aug 02 2012 - 08:42:04 EST


On Thu, Aug 02, 2012 at 09:11:23AM +0200, Jiri Kosina wrote:
> There are multiple errors in how sys_32_personality() handles personality
> flags stored in top three bytes.
>
> - directly comparing current->personality against PER_LINUX32 doesn't work
> in cases when any of the personality flags stored in the top three bytes
> are used.
> - directly forcefully setting personality to PER_LINUX32 or PER_LINUX
> discards any flags stored in the top three bytes
>
> Fix the first one by properly using personality() macro to compare only
> PER_MASK bytes.
> Fix the second one by setting only the bits that should be set, instead of
> overwriting the whole value.

Applied. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/