Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

From: Paul Walmsley
Date: Thu Aug 02 2012 - 03:52:42 EST


Hello OMar,

On Mon, 16 Jul 2012, Omar Ramirez Luna wrote:

> For a reset sequence to complete cleanly, a module needs its
> associated clocks to be enabled, otherwise the timeout check
> in prcm code can print a false failure (failed to hardreset)
> that occurs because the clocks aren't powered ON and the status
> bit checked can't transition without them.
>
> Signed-off-by: Omar Ramirez Luna <omar.luna@xxxxxxxxxx>

Is enabling the clocks sufficient? Or do we also need to enable the
IP block, e.g. by calling

if (soc_ops.enable_module)
soc_ops.enable_module(oh);

as we do on OMAP4+ in _enable() ?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/