Re: [PATCH] MIPS: oops when show backtrace of all active cpu

From: Fan Du
Date: Thu Aug 02 2012 - 00:42:08 EST




On 2012å08æ02æ 12:18, Kevin Cernekee wrote:
On Wed, Aug 1, 2012 at 8:31 PM, Fan Du<fdu@xxxxxxxxxxxxx> wrote:
show_backtrace must have an valid task when calling unwind_stack,
so fix it by checking first.
[...]
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -151,6 +151,10 @@ static void show_backtrace(struct task_struct *task, const struct pt_regs *regs)
show_raw_backtrace(sp);
return;
}
+
+ if (task == NULL)
+ task = current;
+
printk("Call Trace:\n");
do {
print_ip_sym(pc);

FYI, a slightly different version of this change was accepted:

https://patchwork.linux-mips.org/patch/3524/



Oh, Looks like I'm late :)
thanks anyway.


--

Love each day!
--fan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/