Re: [Jfs-discussion] [PATCH] fs/jfs: TRIM support for JFSFilesystem

From: Tino Reichardt
Date: Wed Aug 01 2012 - 16:08:27 EST


* Tino Reichardt <list-linux-fsdevel@xxxxxxxxx> wrote:
> * Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> wrote:
> > On 07/28/2012 06:08 AM, Tino Reichardt wrote:
> > > * Tino Reichardt <list-linux-fsdevel@xxxxxxxxx> wrote:
> > >> > This patch adds support for the two linux interfaces of the discard/TRIM
> > >> > command for SSD devices and sparse/thinly-provisioned LUNs.
> > > Fixed a problem when setting minlen in jfs_ioc_trim().

Oops, setting minlen in jfs_ioc_trim() was again wrong :/

I changed this
if (minlen < 0)
minlen = 1;

to this:
if (minlen <= 0)
minlen = 1;

This is important, since fstrim() sets it to zero.


Fully working patch is located here:
http://www.mcmilk.de/projects/jfs-trim/linux-tree/jfs-trim-2012-08-01_v2.diff

Signed-off-by: Tino Reichardt <list-jfs@xxxxxxxxx>

--
regards, TR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/