Re: [PATCH 23/24] hvc_xen: allow dom0_write_console for HVM guests

From: Konrad Rzeszutek Wilk
Date: Wed Aug 01 2012 - 11:03:27 EST


On Thu, Jul 26, 2012 at 04:34:05PM +0100, Stefano Stabellini wrote:
> On ARM all guests are HVM guests, including Dom0.
> Allow dom0_write_console to be called by an HVM domain.

Um, but xen_hvm_domain() != xen_pv_domain() so won't this return without
printing anything?

>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
> drivers/tty/hvc/hvc_xen.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> index 3c04fb8..949edc2 100644
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -616,12 +616,9 @@ static void xenboot_write_console(struct console *console, const char *string,
> unsigned int linelen, off = 0;
> const char *pos;
>
> - if (!xen_pv_domain())
> - return;
> -
> dom0_write_console(0, string, len);
>
> - if (xen_initial_domain())
> + if (!xen_pv_domain())
> return;
>
> domU_write_console(0, "(early) ", 8);
> --
> 1.7.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/