RE: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses

From: Kukjin Kim
Date: Tue Jul 31 2012 - 19:27:51 EST


Linus Walleij wrote:
>
> On Fri, Jul 20, 2012 at 10:58 PM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
>
> > Move gpc4 to the end of the automatically processed gpio controllers so
> > we don't taint the automatic offset calculation.
> >
> > This bug caused all controllers coming after gpc4 to map to the
> > incorrect address. The result is <&gpd1 0 0 0 0> would actually map to
> > GPIO 0 in gpd0.
> >
> > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
>
> Samsung people, please comment on this patch.
>
Looks good to me, please keep going on.
And feel free to add my ack on this.

Acked-by: Kukjin Kim <kgene.kim@xxxxxxxxxxx>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/