Re: [RFC v2 1/2] PCI-Express Non-Transparent Bridge Support

From: Greg KH
Date: Tue Jul 31 2012 - 18:25:54 EST


On Sun, Jul 29, 2012 at 05:26:33PM -0700, Jon Mason wrote:
> +struct ntb_transport_qp;
> +
> +struct ntb_client {
> + char *name;
> + int (*probe) (struct pci_dev *pdev);
> + void (*remove) (struct pci_dev *pdev);
> +};

Why isn't this tied into the driver model? That looks like you really
want to use a 'struct device' here, right?

Then you have drivers that bind to them, and your devices show up in
sysfs, which is probably a requirement you have, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/