Re: [PATCH 03/11] kdb: Implement disable_nmi command

From: Colin Cross
Date: Mon Jul 30 2012 - 13:35:57 EST


On Mon, Jul 30, 2012 at 4:58 AM, Anton Vorontsov
<anton.vorontsov@xxxxxxxxxx> wrote:
> This command disables NMI-entry. If NMI source was previously shared with
> a serial console ("debug port"), this effectively releases the port from
> KDB exclusive use, and makes the console available for normal use.
>
> Of course, NMI can be reenabled, enable_nmi modparam is used for that:
>
> echo 1 > /sys/module/kdb/parameters/enable_nmi

This is very different behavior from the FIQ debugger "console"
command you are trying to replace. In the FIQ debugger, everything
goes through the FIQ/NMI, even when in console mode. That means that
the user can always get back to FIQ debugger/KDB mode using a special
sequence (we use a break character). With your implementation, if you
switch from KDB to console to see if the console is working, and find
that it is not working, you can never get back into KDB.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/