Re: [PATCH 1/3] mfd: twl6040: Fix GPO mask

[Peter Ujfalusi]

Hello Linus,

On 07/28/2012 01:45 AM, Linus Walleij wrote:
> On Wed, Jul 18, 2012 at 11:20 AM, Peter Ujfalusi <peter.ujfalusi@xxxxxx> wrote:
> 
>>  #define TWL6040_GPO1                   0x01
>>  #define TWL6040_GPO2                   0x02
>> -#define TWL6040_GPO3                   0x03
>> +#define TWL6040_GPO3                   0x04
> 
> Maybe a stupid question but does these register defines really belong in that
> header file? Can't you do a separate patch moving them into the driver per
> se?

I thought about that but in this way the header file can be used as
documentation for the register bits of twl6040.
The GPIO driver do not use these defines, it is using shift to address the
correct bits in the GPO register.

Regards,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/