Re: [PATCH 1/2] sched: recover SD_WAKE_AFFINE in select_task_rq_fairand code clean up

[Alex Shi]

On 07/27/2012 04:32 PM, Peter Zijlstra wrote:

> On Fri, 2012-07-27 at 09:47 +0800, Alex Shi wrote:
> 
>> From 610515185d8a98c14c7c339c25381bc96cd99d93 Mon Sep 17 00:00:00 2001
>> From: Alex Shi <alex.shi@xxxxxxxxx>
>> Date: Thu, 26 Jul 2012 08:55:34 +0800
>> Subject: [PATCH 1/3] sched: recover SD_WAKE_AFFINE in select_task_rq_fair and
>>  code clean up
>>
>> Since power saving code was removed from sched now, the implement
>> code is out of service in this function, and even pollute other logical.
>> like, 'want_sd' never has chance to be set '0', that remove the effect
>> of SD_WAKE_AFFINE here.
>>
>> So, clean up the obsolete code and some other unnecessary code.
>>
>> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxx>
> 
> I think your code leaves an unused definition of SD_PREFER_LOCAL around.




I had thought it maybe useful in power saving recovery. But you are right. 
It is better to remove them and alignment code now. 

===