Re: [PATCH] scripts/patch-kernel fix

From: Michal Marek
Date: Thu Jul 26 2012 - 06:10:42 EST


On 19.7.2012 23:49, Daniel Wisehart wrote:
> diff --git a/scripts/patch-kernel b/scripts/patch-kernel
> index d000ea3..a7672eb 100755
> --- a/scripts/patch-kernel
> +++ b/scripts/patch-kernel
> @@ -226,7 +226,7 @@ fi
>
> # This all assumes a 2.6.x[.y] kernel tree.
> # Don't allow backwards/reverse patching.
> -if [ $STOPSUBLEVEL -lt $SUBLEVEL ]; then
> +if [ "$STOPSUBLEVEL"0 -lt "$SUBLEVEL"0 ]; then

Hi Daniel,

While this is correct, it is not obvious at first sight why you need to
multiply the numbers by 10. Or at least it was not obvious to me :).
Could you use the more common idiom 0$NUMBER? The shell interprets the
numbers as decimal, so it's works fine.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/