Re: [PATCH 16/17] perf, tool: Add dso data caching

From: Frederic Weisbecker
Date: Wed Jul 25 2012 - 13:11:04 EST


On Sun, Jul 22, 2012 at 02:14:39PM +0200, Jiri Olsa wrote:
> Adding dso data caching so we don't need to open/read/close,
> each time we want dso data.
>
> The DSO data caching affects following functions:
> dso__data_read_offset
> dso__data_read_addr
>
> Each DSO read tries to find the data (based on offset) inside
> the cache. If it's not present it fills the cache from file,
> and returns the data. If it is present, data are returned
> with no file read.
>
> Each data read is cached by reading cache page sized/aligned
> amount of DSO data. The cache page size is hardcoded to 4096.
> The cache is using RB tree with file offset as a sort key.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Nice idea.

> ---
> tools/perf/util/symbol.c | 154 ++++++++++++++++++++++++++++++++++++++++------

There seem to be an increasing need to move dso related things
to some util/dso.c file. Just suggesting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/