Re: [PATCH 06/12] perf header: Reconstruct group relationship byparsing cmdline

From: Namhyung Kim
Date: Wed Jul 25 2012 - 11:52:36 EST


2012-07-25 (ì), 17:39 +0200, Jiri Olsa:
> On Tue, Jul 24, 2012 at 06:01:27PM +0900, Namhyung Kim wrote:
> > In order to support the event group viewer, their group relationship
> > is needed. Since it's not recorded explicitly anywhere in the perf.data
> > we should parse saved cmdline and apply the result to the evlist. It is
> > assumed that parsed entries are in a same order with the originals.
> >
> > I know it's fragile but hard to find other way to do it in the current
> > condition. :(
>
> How about storing grouping details in new perf.data feature?
> As you said reparsing looks too fragile.
>
> jirka

Yeah, maybe it's the best thing I can do now.

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/