Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq

From: Wolfram Sang
Date: Tue Jul 24 2012 - 11:29:46 EST


On Mon, Jul 23, 2012 at 12:24:38PM -0600, Stephen Warren wrote:
> On 07/10/2012 05:20 AM, Laxman Dewangan wrote:
> > To provide the late suspend and early resume for i2c
> > driver, convert the suspend/resume as
> > suspend-> suspend_noirq
> > resume -> resume_noirq
> >
> > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
>
> Why do we need this change?
>
> IIRC, I proposed it before solely to solve some suspend/resume ordering
> issues, and Colin Cross NAKd it. These days, deferred probe should make
> this change unnecessary.
>
> Unless there's a really good reason for this change, I'd tend to request
> reverting it.

I will drop it from my tree and exclude it from my pull request. Please
resend if it should go in later.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature