Re: [PATCH 08/11] perf tool: precise mode requires exclude_guest

[David Ahern]

On 7/23/12 12:13 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jul 20, 2012 at 05:25:53PM -0600, David Ahern escreveu:
> > PEBS cannot be used with guest mode. If user adds :p modifier set
> > exclude_guest as well.
>
> Is this something Intel specific? Or can someone think of an arch where
> this limitation wouldn't exist?

Good point. So far precise_ip is used by arch/x86 only. I don't have an 
AMD based server so I don't know if there is a conflict between 
virtualization and IBS. Added Robert for advice.

David

> > Signed-off-by: David Ahern <dsahern@xxxxxxxxx>
> > Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> > Cc: Gleb Natapov <gleb@xxxxxxxxxx>
> > Link: https://lkml.org/lkml/2012/7/9/264
> > ---
> >   tools/perf/util/parse-events.c |    3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> > index 1aa721d..f34629b 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -653,6 +653,9 @@ int parse_events_modifier(struct list_head *list, char *str)
> >   			eH = 0;
> >   		} else if (*str == 'p') {
> >   			precise++;
> > +			/* use of precise requires exclude_guest */
> > +			if (!exclude_GH)
> > +				eG = 1;
> >   		} else
> >   			break;
> >
> > --
> > 1.7.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/