Re: [Bcache v14 PATCH] fix compiler error

From: Kent Overstreet
Date: Mon Jul 23 2012 - 17:12:12 EST


On Thu, Jul 19, 2012 at 04:53:26PM -0400, Daniel Wisehart wrote:
> Hello Kent,
>
> This patch keeps gcc 4.7.0 happy. The static function dump_bset() could be moved, but that would have made a bigger patch. :-)

Thanks! dump_bset() does need to be moved so it's available if DEBUG or
EDEBUG are on, but thanks for pointing it out :)

>
> Thanks,
> Daniel
>
>
>
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index 3c9c24d..4dc0ba5 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -83,6 +83,8 @@ struct keyprint_hack bch_pbtree(const struct btree *b)
>
> #ifdef CONFIG_BCACHE_DEBUG
>
> +static void dump_bset(struct btree *b, struct bset *i);
> +
> void bch_btree_verify(struct btree *b, struct bset *new)
> {
> struct btree *v = b->c->verify_data;
>
>
> This communication is restricted - please see http://www.eladian.com for further information.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/