Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq

From: Stephen Warren
Date: Mon Jul 23 2012 - 14:24:43 EST


On 07/10/2012 05:20 AM, Laxman Dewangan wrote:
> To provide the late suspend and early resume for i2c
> driver, convert the suspend/resume as
> suspend-> suspend_noirq
> resume -> resume_noirq
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

Why do we need this change?

IIRC, I proposed it before solely to solve some suspend/resume ordering
issues, and Colin Cross NAKd it. These days, deferred probe should make
this change unnecessary.

Unless there's a really good reason for this change, I'd tend to request
reverting it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/