Re: [PATCH 09/11] perf top: error handling for counter creationshould parallel perf-record

From: Arnaldo Carvalho de Melo
Date: Mon Jul 23 2012 - 14:15:25 EST


Em Fri, Jul 20, 2012 at 05:25:54PM -0600, David Ahern escreveu:
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index e3cab5f..0ce665c 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -943,8 +943,10 @@ try_again:
> * based cpu-clock-tick sw counter, which
> * is always available even if no PMU support:
> */
> - if (attr->type == PERF_TYPE_HARDWARE &&
> - attr->config == PERF_COUNT_HW_CPU_CYCLES) {
> + if ((err == ENOENT || err == ENXIO)
> + && attr->type == PERF_TYPE_HARDWARE
> + && attr->config == PERF_COUNT_HW_CPU_CYCLES) {
> +

usual style:

if ((err == ENOENT || err == ENXIO) &&
attr->type == PERF_TYPE_HARDWARE &&
attr->config == PERF_COUNT_HW_CPU_CYCLES) {

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/