Re: [PATCH] apple-gmux: Fix kconfig dependencies
From: Matthew Garrett
Date: Mon Jul 23 2012 - 09:30:09 EST
On Mon, Jul 16, 2012 at 04:50:34PM -0700, Seth Forshee wrote:
> On Mon, Jul 02, 2012 at 09:55:29AM -0500, Seth Forshee wrote:
> > Fix the dependencies of apple-gmux to prevent it from being built-in
> > when one or more of its dependencies is built as a module. Otherwise it
> > can fail to build due to missing symbols.
> Matthew: Are you okay with this, or is there some better way to do it?
I think this is probably about as good as it gets.
> I'm looking at Andreas's code for switcharoo support, and something I
> want to do along with it is make apple-gmux not dependent on backlight
> support (i.e. you can still build switcharoo support if
> BACKLIGHT_CLASS_DEVICE is disabled). I'm assuming this patch as a
> prerequisite. But things do get really monstrously ugly, so if there's a
> cleaner way to enforce this that I haven't found I'd love to hear about
Why do you want to support that case? One of the problems we have with
the kernel at present is that it's trivial to come up with non-sensical
configurations. I can't think of a single case where you'd want the gmux
support without also having the backlight support code.
Matthew Garrett | mjg59@xxxxxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/