Re: [PATCH] gpiolib: Use seq_file's iterator interface
From: Thierry Reding
Date: Mon Jul 23 2012 - 08:12:35 EST
On Sat, May 12, 2012 at 12:56:14PM +0000, Arnd Bergmann wrote:
> On Thursday 12 April 2012, Thierry Reding wrote:
> > When dumping a collection of items via seq_file, it is recommended to
> > use the iterator interface. For the gpiolib debugfs interface this can
> > be done to dump each GPIO chip in turn.
> > Note that for gpiolib this is a little cumbersome because it does not
> > provide a list of registered GPIO chips and the only way to iterate is
> > over each GPIO individually. Once a chip is found, the number of GPIOs
> > it provides can be skipped as a small optimization.
> > This patch was requested by Arnd Bergmann here:
> > http://article.gmane.org/gmane.linux.ports.tegra/3535
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> > Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
Is this good to go?
Description: PGP signature