RE: [PATCH] thermal: fix build error at thermal_sys.c
From: R, Durgadoss
Date: Sun Jul 22 2012 - 23:08:08 EST
> -----Original Message-----
> From: Jean Delvare [mailto:khali@xxxxxxxxxxxx]
> Sent: Sunday, July 22, 2012 4:28 PM
> To: Devendra Naga; Zhang, Rui
> Cc: Brown, Len; Andrew Morton; Joe Perches; linux-kernel@xxxxxxxxxxxxxxx;
> Fengguang Wu; R, Durgadoss
> Subject: Re: [PATCH] thermal: fix build error at thermal_sys.c
> On Sun, 22 Jul 2012 13:55:22 +0545, Devendra Naga wrote:
> > with the commit 67ff19 (Thermal: Make Thermal trip points writeable)
> > build error is introduced,
> > the following was reported from Fengguang Wu,
> > drivers/thermal/thermal_sys.c: In function 'create_trip_attrs':
> > drivers/thermal/thermal_sys.c:1216:3: error: 'count' undeclared (first use in this
> > drivers/thermal/thermal_sys.c:1216:3: note: each undeclared identifier is
> reported only once for each function it appears in
> > link:
> > http://www.spinics.net/lists/linux-kernel-janitors/msg12174.html
> > use the indx instead.
> Thanks for the fix.
> > Cc: Durgadoss R <durgadoss.r@xxxxxxxxx>
> > Signed-off-by: Devendra Naga <develkernel412222@xxxxxxxxx>
> > ---
> > This patch is build-tested only.
> Something the original submitter apparently didn't do. Durga, can you
> please build-test all your commits from now on? I don't even understand
> how you managed to test your code if it did not build...
I did build and functionality test also (as I had other patches to test on top of this),
on these patch sets; but wondering how it got introduced in this patch set..
Anyway, I will take care of these stupidities going forward.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/