[ 052/108] atl1c: fix issue of transmit queue 0 timed out

From: Ben Hutchings
Date: Sun Jul 22 2012 - 21:43:24 EST

3.2-stable review patch. If anyone has any objections, please let me know.


From: Cloud Ren <cjren@xxxxxxxxxxxxxxxx>

commit b94e52f62683dc0b00c6d1b58b80929a078c0fd5 upstream.

some people report atl1c could cause system hang with following
kernel trace info:
WARNING: at.../net/sched/sch_generic.c:258 dev_watchdog+0x1db/0x1d0()
NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out
This is caused by netif_stop_queue calling when cable Link is down.
So remove netif_stop_queue, because link_watch will take it over.

Signed-off-by: xiong <xiong@xxxxxxxxxxxxxxxx>
Signed-off-by: Cloud Ren <cjren@xxxxxxxxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -267,7 +267,6 @@ static void atl1c_check_link_status(stru
dev_warn(&pdev->dev, "stop mac failed\n");
atl1c_set_aspm(hw, false);
- netif_stop_queue(netdev);
} else {

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/