Re: [PATCH] net: Fix references to out-of-scope variables input_cmsg_compat()

From: David Miller
Date: Sun Jul 22 2012 - 17:54:12 EST

From: Jesper Juhl <jj@xxxxxxxxxxxxx>
Date: Sun, 22 Jul 2012 23:37:20 +0200 (CEST)

> In net/compat.c::put_cmsg_compat() we may assign 'data' the address of
> either the 'ctv' or 'cts' local variables inside the 'if
> (!COMPAT_USE_64BIT_TIME)' branch.
> Those variables go out of scope at the end of the 'if' statement, so
> when we use 'data' further down in 'copy_to_user(CMSG_COMPAT_DATA(cm),
> data, cmlen - sizeof(struct compat_cmsghdr))' there's no telling what
> it may be refering to - not good.
> Fix the problem by simply giving 'ctv' and 'cts' function scope.
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Applied and queued up for -stable, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at