Re: [PATCH 1/2] kthread_worker: reorganize to prepare forflush_kthread_work() reimplementation

From: Andy Walls
Date: Sun Jul 22 2012 - 16:42:50 EST


On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote:
> Hello,
>
> On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote:
> > > +/* insert @work before @pos in @worker */
> >
> > Hi Tejun,
> >
> > Would a comment that the caller should be holding worker->lock be useful
> > here? Anyway, comment or not:
> >
> > Acked-by: Andy Walls <awall@xxxxxxxxxxxxxxxx>
>
> Will add lockdep_assert_held(). Thanks!
>

Great! Thank you.

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/