Re: [PATCHSET] workqueue: reimplement CPU hotplug to keep idleworkers

From: Peter Zijlstra
Date: Fri Jul 20 2012 - 12:40:13 EST


On Tue, 2012-07-17 at 10:12 -0700, Tejun Heo wrote:
> Currently, workqueue destroys all workers for offline CPUs unless
> there are lingering work items.

_that_ is the root of all ugly in that thing. I still find it utterly
insane you can create 'per-cpu' workqueues and then violate the per-cpu
property with hotplug and get your work ran on a different CPU.

It should be a hard error to use queue_work_on() and then run the work
on a different cpu. Yet somehow this isn't so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/