Re: [RFC][PATCH v2 2/3] Hold multiple logs
From: Don Zickus
Date: Fri Jul 20 2012 - 10:29:40 EST
On Fri, Jul 20, 2012 at 01:24:38PM +0000, Seiji Aguchi wrote:
> > What is the harm of not using this and just letting the number be infinite (or until EFI runs out of space)? Is it a big deal if extra failures
> > are logged?
> There may be someone using NVRAM for other purposes.
> Actually, we have the user interface, /sys/firmware/efi/vars/new_vars, del_vars.
> In this case, they want to avoid filling with unneeded logs.
Sure, which is why it needs to be cleaned out regularly. This isn't much
different than with /var/logs or even /boot. The former can suck up lots
of disk space for no reason and the later can use up limited space if you
install to many kernels.
I don't know, I am not a fan of this policy in the kernel, I would rather
keep it simple, like an on/off switch. If you decide you want to use efi
for logging than you better make sure you have an app to clean it up.
Otherwise the user shouldn't turn it on.
Creating rules like this seems to be complicating things to me IMHO. But
I will gladly defer to someone else's judgement.
> > The hope would be a daemon would clear the old logs out and you never run out of space.
> In most case
> But as Tony mentioned, NVRAM may be filled with multiple oops even if we have the daemon.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/