Re: [PATCH] [TRIVIAL] treewide: fix four odd angle bracketincludes

From: Jiri Kosina
Date: Fri Jul 20 2012 - 04:28:41 EST


On Fri, 29 Jun 2012, Paul Bolle wrote:

> The paths of the headers included by four "angle brackets includes"
> start with "..". So these includes are used to include headers that are
> not actually found in the include search path. Then we might as well
> include these headers using quote marks and paths that link directly to
> these headers.

Right, but ... I don't really see the value of switching either way, do
you?

>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> 0) mtip32xx.c and progress.h were compile tested. The other two files
> are $EDITOR tested only. (Ie, my $EDITOR knows how to jump to the
> included header from these #include lines, so the preprocessor must
> surely know how to do that too.)
>
> 1) board-rx51-peripherals.c includes a header from a staging driver.
> That's, well, surprising.

Now, that is ugly. Adding Tony Lindgren to CC.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/