[patch] driver-core: dev_to_node() should handle NULL pointers

From: Dan Carpenter
Date: Fri Jul 20 2012 - 02:56:37 EST

What prompted this patch is that in dma_pool_create() we call
dev_to_node() before checking whether "dev" is NULL. It looks like
there are places which call dma_pool_create() with a NULL pointer. An
example is in drivers/usb/gadget/amd5536udc.c.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Static checker fix.

diff --git a/include/linux/device.h b/include/linux/device.h
index aa7b3b4..c80e7a8d 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -714,7 +714,9 @@ int dev_set_name(struct device *dev, const char *name, ...);
static inline int dev_to_node(struct device *dev)
- return dev->numa_node;
+ if (dev)
+ return dev->numa_node;
+ return -1;
static inline void set_dev_node(struct device *dev, int node)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/