[PATCH 01/90 v2] staging: comedi: comedidev.h: introduce comedi_to_pci_dev() helper

From: H Hartley Sweeten
Date: Thu Jul 19 2012 - 13:39:44 EST

Introduce a wrapper for to_pci_dev() to allow the comedi_pci_drivers
to store the pci_dev pointer in the comedi_device hw_dev variable and
retrieve it easily.

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbot <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
v2: Ian Abbott pointed out that the dev->hw_dev needs to be checked
that it's non-NULL before passing it to to_pci_dev(). As Dan
Carpenter pointed out, the container_of() just does pointer math
with the offset. If you give it a NULL pointer it returns a
bogus pointer back.

drivers/staging/comedi/comedidev.h | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
index de8c99c..f713783 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -446,6 +446,11 @@ static inline void comedi_set_hw_dev(struct comedi_device *dev,

+static inline struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev)
+ return dev->hw_dev ? to_pci_dev(dev->hw_dev) : NULL;
int comedi_buf_put(struct comedi_async *async, short x);
int comedi_buf_get(struct comedi_async *async, short *x);


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/