Re: [PATCH] PCDP: use early_ioremap/early_iounmap to access pcdptable

From: Khalid Aziz
Date: Thu Jul 19 2012 - 11:27:50 EST


On Wed, 2012-07-18 at 16:19 -0600, Greg Pearson wrote:
> Signed-off-by: Greg Pearson <greg.pearson@xxxxxx>
> ---
> drivers/firmware/pcdp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/pcdp.c b/drivers/firmware/pcdp.c
> index 51e0e2d..a330492 100644
> --- a/drivers/firmware/pcdp.c
> +++ b/drivers/firmware/pcdp.c
> @@ -95,7 +95,7 @@ efi_setup_pcdp_console(char *cmdline)
> if (efi.hcdp == EFI_INVALID_TABLE_ADDR)
> return -ENODEV;
>
> - pcdp = ioremap(efi.hcdp, 4096);
> + pcdp = early_ioremap(efi.hcdp, 4096);
> printk(KERN_INFO "PCDP: v%d at 0x%lx\n", pcdp->rev, efi.hcdp);
>
> if (strstr(cmdline, "console=hcdp")) {
> @@ -131,6 +131,6 @@ efi_setup_pcdp_console(char *cmdline)
> }
>
> out:
> - iounmap(pcdp);
> + early_iounmap(pcdp, 4096);
> return rc;
> }

This looks good to me.

Acked-by: Khalid Aziz <khalid.aziz@xxxxxx>

--
Khalid Aziz <khalid.aziz@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/