Re: [PATCH 32/90] staging: comedi: amplc_pc236: store the pci_devin the comedi_device
From: Ian Abbott
Date: Thu Jul 19 2012 - 06:30:35 EST
On 2012-07-19 02:39, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit. Remove the IS_ENABLED() tests in
the detach. If the pci_dev is non NULL it's a PCI device otherwise
it's an ISA device. Using IS_ENABLED() to omit the code paths
makes the code a bit confusing and doesn't save much.
The detach() routine should really check thisboard->bustype for
robustness, as NULL hw_dev doesn't necessarily mean its a PCI device.
The original code should have checked thisboard->bustype too although it
works by accident because dev->iobase is 0.
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/