Re: [PATCH 22/90] staging: comedi: adv_pci_dio: remove CheckAndAllocCard()

From: Ian Abbott
Date: Thu Jul 19 2012 - 05:50:58 EST


On 2012-07-19 02:34, H Hartley Sweeten wrote:
This driver creates a linked list of all the pci devices in
the system while it's looking for a match. It's only use is
to determine if a device is "free" to use. The pci_is_enabled()
helper can give us the same information. Use that instead and
remove the linked list.

As mentioned in my replies to your patches to adv_pci1723 and adv_pci1710, pci_is_enabled() might not be sufficient. I think it's better just to take out the free/in-use test.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/