Re: [PATCH RESEND v7 2/2] mmc: card: Adding support for sanitize in eMMC 4.5

[Chris Ball]

Hi Yaniv,

On Thu, Jun 28 2012, Yaniv Gardi wrote:
> This feature delete the unmap memory region of the eMMC card,
> by writing to a specific register in the EXT_CSD
> unmap region is the memory region that were previously deleted
> (by erase, trim or discard operation)
>
> Signed-off-by: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>

Did you reply to Chuanxiao's review comments yet?  He said:

"So to implement your scenario, how about only add
mmc_blk_issue_sanitize_rq() for REQ_SANITIZE but not touch
mmc_blk_issue_secdiscard_rq()? With your changes in
mmc_blk_issue_secdiscard_rq(), eMMC4.5 device will be failed to operate
secure trim/erase for REQ_SECURE request."

at: http://thread.gmane.org/gmane.linux.kernel.mmc/14822/focus=14880

Thanks,

- Chris.
-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/