Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long valuesof flush
From: Jim Rees
Date: Wed Jul 18 2012 - 19:04:57 EST
Sasha Levin wrote:
> Learning from what happened in this specific case, there are actually 2 issues here:
> - Array size was constant and too small, which is solved by the patch above.
> - We were blindly trying to sprintf() into that array, this issue may pop back up if someone decides to change the format string forgetting to modify the array declaration.
The original patch changed the sprintf to snprintf, and that still seems
like a good idea.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/