Re: [PATCH v3 2/3] cgroup: revise how we re-populate root directory

From: Tejun Heo
Date: Wed Jul 18 2012 - 12:32:32 EST


On Wed, Jul 18, 2012 at 10:16:05AM -0400, Aristeu Rozanski wrote:
> > Yeah, generally looks good to me although @added/removed_bits argument
> > names irk me a bit. The name may be okay for local variables but I
> > keep thinking "what bits?". @subsys_mask or something indicating that
> > it's mask of subsystems would better. Also, can you please add /**
> > function comment explaining the clear/populate functions and their
> > arguments?
> agreed. although the "_bits" thing is spread all around the code. you
> want that cleaned up too? (I can post a followup patch after this
> patchset is done)

Yeah, that would be great.

Thanks a lot!

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at