Re: [offlist] uprobe: checking probe event include directory

From: Jovi Zhang
Date: Wed Jul 18 2012 - 07:38:22 EST

On Wed, Jul 18, 2012 at 7:07 PM, Srikar Dronamraju
<srikar@xxxxxxxxxxxxxxxxxx> wrote:
> The patch looks good,
> Can you modify the description a bit. However you are free to ignore
> these comments. After knowing your response, I will ack the patch.
> I would probably put this as:
> The subject could be
> tracing: Verify target file before registering a uprobe event
> Description:
> Without this patch, we can register a uprobe event for a directory.
> Enabling such a uprobe event would anyway fail.
> Example:
> $ echo 'p /bin:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> However directories cannot be valid targets for uprobe.
> Hence verify if the target is a regular file during the probe
> registration.

Thanks srikar, your description is more clear than mine.