Re: [PATCH] mfd: MAX77693: Fix bug of interrupt handlding forMAX77693 devices

From: Mark Brown
Date: Tue Jul 17 2012 - 15:14:49 EST

On Tue, Jul 17, 2012 at 08:30:17AM +0900, Chanwoo Choi wrote:
> On 07/16/2012 10:36 PM, Mark Brown wrote:
> > On Mon, Jul 16, 2012 at 06:41:05PM +0900, Chanwoo Choi wrote:

> >> This patch fix bug related to interrupt handling for MAX77693 devices.
> >> - Unmask interrupt masking bit for charger/flash/muic to revolve
> >> that interrupt isn't happened when external connector is attached.

> > Shouldn't this be happening when the IRQ is requested?

> The interrupt isn't happened when external connector is attached
> because muic interrupt of MAX77693 is masked on INTSRC_MASK(
> Interrupt Source Mask) register. So, I should set zero to muic interrupt
> masking bit of INTSRC_MASK before requesting IRQ.

Right, but normally that unmasking happens in the unmask() callback of
the irq_chip which is called when the interrupt is requested. Why isn't
that working here?

Attachment: signature.asc
Description: Digital signature