Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe:undefined reference to `rand_initialize_irq')

From: Linus Walleij
Date: Tue Jul 17 2012 - 14:40:49 EST


On Tue, Jul 17, 2012 at 12:39 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
> On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek <sedat.dilek@xxxxxxxxx> wrote:
>> ...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
>>
>> drivers/mfd/ab3100-core.c:939: rand_initialize_irq(client->irq);
>>
>> ...but why has random.h still this...?
>>
>> include/linux/random.h:51:extern void rand_initialize_irq(int irq);
>>
>> Just thinking "loud"...
>>
>> - Sedat -
>
> Is this attached patch OK, Ted?

You're just deleting a line from the AB3100 driver, so I guess you're
regressing the system since that IRQ will no longer contribute
to the entropy pool?

How do we simultaneously make sure that this IRQ is still
contributing to the entropy?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/