Re: [PATCH RFC] swiotlb: Disable swiotlb overflow support whenCONFIG_ISA is enabled

From: Shuah Khan
Date: Tue Jul 17 2012 - 14:27:29 EST

On Mon, 2012-07-16 at 12:01 -0400, Konrad Rzeszutek Wilk wrote:

> > > The first goal is to figure out which of the drivers aren't doing this
> > > properly. This should be possible by just grepping for 'dma_map' and
> > > seeing which ones don't do the 'dma_check' right after.
> >

I did cscope searches two different ways on linux-next July 12th git

map_page - in this case I looked at all of the dma_ops.map_page() calls
to see if they are followed by dma_mapping_error() calls. Found the
following cases that don't check map_page() return value.

arch/powerpc/platforms/cell/iommu.c - dma_fixed_map_page()
drivers/net/ethernet/sun/niu.c - niu_rbr_add_page()
net/sunrpc/xprtrdma/svc_rdma_sendto.c - dma_map_xdr()

dma_map - in this case again I looked for calls to dma_map(). Found the
following cases where return isn't checked:


I am somewhat surprised to find only a few cases. Hoping I covered all
the bases, can you think of anything else I should look for before
concluding these are the cases that need fixing?

-- Shuah

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at