Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

From: Greg Kroah-Hartman
Date: Tue Jul 17 2012 - 14:18:16 EST

On Tue, Jul 17, 2012 at 11:09:18AM -0700, Anton Vorontsov wrote:
> On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote:
> [...]
> > That's nice, but it breaks the build on my system as linux_banner
> > somehow isn't enabled as part of the build?
> I really don't see how you managed to disable it. :-)
> init/version.c is built unconditionally, and it has
> 'const char linux_banner[]' unconditionally. Then ram.c includes
> kernel.h, which unconditionally (well, under #ifdef __KERNEL__)
> includes printk.h, which has 'extern const char linux_banner[];'
> prototype...
> I'm still looking further, but can you please send your config
> file? And may be gcc version?

It failed in the linking stage, so perhaps it is because linux_banner is
not exported and you had module code looking for it?

.config is attached.


greg k-h

Attachment: .config
Description: application/config